-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Simplify bulk action execution #143019
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
force-pushed
the
improve-bulk-action-executor
branch
from
October 11, 2022 06:50
a2d5d1a
to
1b51e04
Compare
maximpn
added
enhancement
New value added to drive a business result
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Detection Rule Management
Security Detection Rule Management Team
Feature:Rule Management
Security Solution Detection Rule Management
labels
Oct 11, 2022
maximpn
force-pushed
the
improve-bulk-action-executor
branch
from
October 11, 2022 10:35
1808259
to
fc207d2
Compare
maximpn
force-pushed
the
improve-bulk-action-executor
branch
from
October 11, 2022 14:47
4a4fc7d
to
d35d0d3
Compare
maximpn
added
v8.6.0
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
labels
Oct 11, 2022
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @maximpn |
Closed this PR in favor of #144016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New value added to drive a business result
Feature:Rule Management
Security Solution Detection Rule Management
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
Team:Detection Rule Management
Security Detection Rule Management Team
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify bulk action execution. Simple composable functions allow to easily extend the functionality, simplify unit testing and reduce the overall complexity.
Details
The refactoring follows single responsibility and composability principles.
executeRulesBulkAction
function is removed in favour ofexecuteRulesBulkAction
andperformBulkExportAction
. A separateperformBulkExportAction
function allows to highlight it is used in a different way. On top of that in place errors handling localises the functionality which avoid to exposes local functions.Checklist